Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default parameter location based on consumes #927

Merged
merged 5 commits into from
May 10, 2024
Merged

Set default parameter location based on consumes #927

merged 5 commits into from
May 10, 2024

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented May 7, 2024

Just a fork of #880 that is based on the latest changes in master.

LeFnord
LeFnord reviewed May 8, 2024
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
LeFnord
LeFnord reviewed May 8, 2024
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dhruvCW …
but I have one big question, ite seems now the consumes key must be given,
is ot what you want?
want to see a fallback, if it isn't defined then json should be consumed

@dhruvCW
Copy link
Contributor Author

dhruvCW commented May 9, 2024

thanks @dhruvCW … but I have one big question, ite seems now the consumes key must be given, is ot what you want? want to see a fallback, if it isn't defined then json should be consumed

Hey 👋

we use consumes from the method[:consumes] value this is by default set to application/json so I think that should be enough of a fallback. Or am I not understanding your concern 😅

@dhruvCW dhruvCW requested a review from LeFnord May 9, 2024 09:12
LeFnord
LeFnord approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @dhruvCW it makes sense, thanks

@LeFnord LeFnord merged commit e7856de into ruby-grape:master May 10, 2024
21 checks passed
@dhruvCW dhruvCW deleted the params_based_on_consumes branch May 10, 2024 11:02
This was referenced May 10, 2024
Closed
Closed
@LeFnord LeFnord mentioned this pull request May 13, 2024
Merged
@LeFnord LeFnord mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvCW @LeFnord @spaceraccoon